netdev - Re: [PATCH net] net: ipa: add an interconnect dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220228213509.64434f4b@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Mon, 28 Feb 2022 21:35:09 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Alex Elder <elder@...aro.org>
Cc:     davem@...emloft.net, bjorn.andersson@...aro.org, mka@...omium.org,
        evgreen@...omium.org, cpratapa@...eaurora.org,
        avuyyuru@...eaurora.org, jponduru@...eaurora.org,
        subashab@...eaurora.org, elder@...nel.org, lkp@...el.com,
        netdev@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: ipa: add an interconnect dependency

On Sat, 26 Feb 2022 13:57:47 -0600 Alex Elder wrote:
> In order to function, the IPA driver very clearly requires the
> interconnect framework to be enabled in the kernel configuration.
> State that dependency in the Kconfig file.
> 
> This became a problem when CONFIG_COMPILE_TEST support was added.
> Non-Qualcomm platforms won't necessarily enable CONFIG_INTERCONNECT.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: 38a4066f593c5 ("net: ipa: support COMPILE_TEST")
> Signed-off-by: Alex Elder <elder@...aro.org>
> ---
>  drivers/net/ipa/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ipa/Kconfig b/drivers/net/ipa/Kconfig
> index d037682fb7adb..3e0da1e764718 100644
> --- a/drivers/net/ipa/Kconfig
> +++ b/drivers/net/ipa/Kconfig
> @@ -2,6 +2,7 @@ config QCOM_IPA
>  	tristate "Qualcomm IPA support"
>  	depends on NET && QCOM_SMEM
>  	depends on ARCH_QCOM || COMPILE_TEST
> +	depends on INTERCONNECT
>  	depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST)
>  	select QCOM_MDT_LOADER if ARCH_QCOM
>  	select QCOM_SCM

Looks like this patch was based on a tree without the QCOM_AOSS_QMP
dependency patch, please rebase and repost.