netdev - Re: [PATCH 2/2] Revert "xfrm: state and policy should fail if XFRMA_IF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220228224332.0cca8d99@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Mon, 28 Feb 2022 22:43:32 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Kai Lüke <kailueke@...ux.microsoft.com>
Cc:     netdev@...r.kernel.org,
        Steffen Klassert <steffen.klassert@...unet.com>,
        Eyal Birger <eyal.birger@...il.com>
Subject: Re: [PATCH 2/2] Revert "xfrm: state and policy should fail if
 XFRMA_IF_ID 0"

On Mon, 28 Feb 2022 19:53:59 +0100 Kai Lüke wrote:
> This reverts commit 68ac0f3810e76a853b5f7b90601a05c3048b8b54 because it
> breaks userspace (e.g., Cilium is affected because it used id 0 for the
> dummy state https://github.com/cilium/cilium/pull/18789).
> 
> Signed-off-by: Kai Lueke <kailueke@...ux.microsoft.com>

What's the story here? You posted your patches twice and they look
white space damaged (tabs replaced by spaces). Does commit 6d0d95a1c2b0
("xfrm: fix the if_id check in changelink") which is in net/master now
solve the issue for you?