netdev - Re: [PATCH net-next] ptp: ocp: Add ptp_ocp_adjtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220302164800.fdfnmutc7f7zb3ek@bsd-mbp.dhcp.thefacebook.com>
Date:   Wed, 2 Mar 2022 08:48:00 -0800
From:   Jonathan Lemon <jonathan.lemon@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        richardcochran@...il.com, kernel-team@...com
Subject: Re: [PATCH net-next] ptp: ocp: Add ptp_ocp_adjtime_coarse for large
 adjustments

On Tue, Mar 01, 2022 at 06:21:53PM -0800, Jakub Kicinski wrote:
> On Mon, 28 Feb 2022 12:39:57 -0800 Jonathan Lemon wrote:
> > In ("ptp: ocp: Have FPGA fold in ns adjustment for adjtime."), the
> > ns adjustment was written to the FPGA register, so the clock could
> > accurately perform adjustments.
> > 
> > However, the adjtime() call passes in a s64, while the clock adjustment
> > registers use a s32.  When trying to perform adjustments with a large
> > value (37 sec), things fail.
> > 
> > Examine the incoming delta, and if larger than 1 sec, use the original
> > (coarse) adjustment method.  If smaller than 1 sec, then allow the
> > FPGA to fold in the changes over a 1 second window.
> > 
> > Fixes: 6d59d4fa1789 ("ptp: ocp: Have FPGA fold in ns adjustment for adjtime.")
> > Signed-off-by: Jonathan Lemon <jonathan.lemon@...il.com>
> 
> This one's tagged for net-next - do you intend for it to go to net-next,
> or is that a typo?

I build and test net-next, so that was my target.
-- 
Jonathan