netdev - RE: [Intel-wired-lan] [PATCH intel-net] ixgbe: xsk: change !netif_carrier_ok() handling in ixgbe_xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MW3PR11MB45547E1C71573E66FEE94F409C039@MW3PR11MB4554.namprd11.prod.outlook.com>
Date:   Wed, 2 Mar 2022 05:49:17 +0000
From:   "Penigalapati, Sandeep" <sandeep.penigalapati@...el.com>
To:     "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC:     Maurice Baijens <maurice.baijens@...ips.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH intel-net] ixgbe: xsk: change
 !netif_carrier_ok() handling in ixgbe_xmit_zc()

>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
>Maciej Fijalkowski
>Sent: Thursday, February 3, 2022 6:28 PM
>To: intel-wired-lan@...ts.osuosl.org
>Cc: Maurice Baijens <maurice.baijens@...ips.com>; netdev@...r.kernel.org;
>kuba@...nel.org; bpf@...r.kernel.org; davem@...emloft.net; Karlsson,
>Magnus <magnus.karlsson@...el.com>
>Subject: [Intel-wired-lan] [PATCH intel-net] ixgbe: xsk: change
>!netif_carrier_ok() handling in ixgbe_xmit_zc()
>
>Commit c685c69fba71 ("ixgbe: don't do any AF_XDP zero-copy transmit if netif
>is not OK") addressed the ring transient state when
>MEM_TYPE_XSK_BUFF_POOL was being configured which in turn caused the
>interface to through down/up. Maurice reported that when carrier is not ok
>and xsk_pool is present on ring pair, ksoftirqd will consume 100% CPU cycles
>due to the constant NAPI rescheduling as ixgbe_poll() states that there is still
>some work to be done.
>
>To fix this, do not set work_done to false for a !netif_carrier_ok().
>
>Fixes: c685c69fba71 ("ixgbe: don't do any AF_XDP zero-copy transmit if netif is
>not OK")
>Reported-by: Maurice Baijens <maurice.baijens@...ips.com>
>Tested-by: Maurice Baijens <maurice.baijens@...ips.com>
>Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
>---
> drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
Tested-by: Sandeep Penigalapati <sandeep.penigalapati@...el.com>