netdev - Re: [PATCH iproute2-next v2] ss: display advertised TCP receive window and out-of-order counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Mar 2022 10:33:28 -0500
From:   Neal Cardwell <ncardwell@...gle.com>
To:     Davide Caratti <dcaratti@...hat.com>
Cc:     dsahern@...nel.org, netdev@...r.kernel.org, sbrivio@...hat.com,
        tph@...com
Subject: Re: [PATCH iproute2-next v2] ss: display advertised TCP receive
 window and out-of-order counter

On Thu, Mar 3, 2022 at 10:19 AM Davide Caratti <dcaratti@...hat.com> wrote:
>
> these members of TCP_INFO have been included in v5.4.
>
> tested with:
>  # ss -nti
>
> Signed-off-by: Davide Caratti <dcaratti@...hat.com>
> ---
>  misc/ss.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/misc/ss.c b/misc/ss.c
> index f7d369142d93..5e7e84ee819e 100644
> --- a/misc/ss.c
> +++ b/misc/ss.c
> @@ -854,6 +854,8 @@ struct tcpstat {
>         unsigned int        reord_seen;
>         double              rcv_rtt;
>         double              min_rtt;
> +       unsigned int        rcv_ooopack;
> +       unsigned int        snd_wnd;
>         int                 rcv_space;
>         unsigned int        rcv_ssthresh;
>         unsigned long long  busy_time;
> @@ -2654,6 +2656,10 @@ static void tcp_stats_print(struct tcpstat *s)
>                 out(" notsent:%u", s->not_sent);
>         if (s->min_rtt)
>                 out(" minrtt:%g", s->min_rtt);
> +       if (s->rcv_ooopack)
> +               out(" rcv_ooopack:%u", s->rcv_ooopack);
> +       if (s->snd_wnd)
> +               out(" snd_wnd:%u", s->snd_wnd);
>  }
>
>  static void tcp_timer_print(struct tcpstat *s)
> @@ -3088,6 +3094,8 @@ static void tcp_show_info(const struct nlmsghdr *nlh, struct inet_diag_msg *r,
>                 s.reord_seen = info->tcpi_reord_seen;
>                 s.bytes_sent = info->tcpi_bytes_sent;
>                 s.bytes_retrans = info->tcpi_bytes_retrans;
> +               s.rcv_ooopack = info->tcpi_rcv_ooopack;
> +               s.snd_wnd = info->tcpi_snd_wnd;
>                 tcp_stats_print(&s);
>                 free(s.dctcp);
>                 free(s.bbr_info);
> --

Acked-by: Neal Cardwell <ncardwell@...gle.com>

Thanks for adding these!

neal