netdev - Re: [PATCH net 2/2] ice: avoid XDP checks in ice_clean_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 3 Mar 2022 10:25:13 -0800
From:   Tony Nguyen <anthony.l.nguyen@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <davem@...emloft.net>,
        Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
        <netdev@...r.kernel.org>, <magnus.karlsson@...el.com>,
        <ast@...nel.org>, <daniel@...earbox.net>, <hawk@...nel.org>,
        <john.fastabend@...il.com>, <bpf@...r.kernel.org>,
        <andrii@...nel.org>, <kpsingh@...nel.org>, <kafai@...com>,
        <yhs@...com>, <songliubraving@...com>,
        Alexander Lobakin <alexandr.lobakin@...el.com>,
        Kiran Bhandare <kiranx.bhandare@...el.com>
Subject: Re: [PATCH net 2/2] ice: avoid XDP checks in ice_clean_tx_irq()


On 3/3/2022 8:28 AM, Jakub Kicinski wrote:
> On Thu, 3 Mar 2022 08:19:01 -0800 Jakub Kicinski wrote:
>> On Wed,  2 Mar 2022 09:59:28 -0800 Tony Nguyen wrote:
>>> From: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
>>>
>>> Commit 9610bd988df9 ("ice: optimize XDP_TX workloads") introduced Tx IRQ
>>> cleaning routine dedicated for XDP rings. Currently it is impossible to
>>> call ice_clean_tx_irq() against XDP ring, so it is safe to drop
>>> ice_ring_is_xdp() calls in there.
>>>
>>> Fixes: 1c96c16858ba ("ice: update to newer kernel API")
>>> Fixes: cc14db11c8a4 ("ice: use prefetch methods")
>>> Reviewed-by: Alexander Lobakin <alexandr.lobakin@...el.com>
>>> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
>>> Tested-by: Kiran Bhandare <kiranx.bhandare@...el.com>  (A Contingent Worker at Intel)
>>> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
>> Is this really a fix?
> I'll apply patch 1 from the list, please reroute this one to net-next.

Thanks Jakub, will do.

-Tony