netdev - Re: [PATCH net-next v1] flow_dissector: Add support for HSR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 Mar 2022 22:44:25 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Kurt Kanzenbach <kurt@...utronix.de>
Cc:     "David S. Miller" <davem@...emloft.net>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Alexander Lobakin <alobakin@...me>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Eric Dumazet <edumazet@...gle.com>,
        Paul Blakey <paulb@...dia.com>,
        Yoshiki Komachi <komachi.yoshiki@...il.com>,
        zhang kai <zhangkaiheb@....com>,
        Juhee Kang <claudiajkang@...il.com>,
        Andreas Oetken <ennoerlangen@...il.com>,
        George McCollister <george.mccollister@...il.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        netdev@...r.kernel.org,
        Anthony Harivel <anthony.harivel@...utronix.de>
Subject: Re: [PATCH net-next v1] flow_dissector: Add support for HSR

On Mon, 28 Feb 2022 20:58:56 +0100 Kurt Kanzenbach wrote:
> Network drivers such as igb or igc call eth_get_headlen() to determine the
> header length for their to be constructed skbs in receive path.
> 
> When running HSR on top of these drivers, it results in triggering BUG_ON() in
> skb_pull(). The reason is the skb headlen is not sufficient for HSR to work
> correctly. skb_pull() notices that.

Should that also be fixed? BUG_ON() seems pretty drastic.

> For instance, eth_get_headlen() returns 14 bytes for TCP traffic over HSR which
> is not correct. The problem is, the flow dissection code does not take HSR into
> account. Therefore, add support for it.