lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 2 Mar 2022 16:36:28 -0800
From:   Eric Dumazet <>
To:     Martin KaFai Lau <>
Cc:     bpf <>, netdev <>,
        Alexei Starovoitov <>,
        Andrii Nakryiko <>,
        Daniel Borkmann <>,
        David Miller <>,
        Jakub Kicinski <>,
        kernel-team <>,
        Willem de Bruijn <>
Subject: Re: [PATCH v6 net-next 0/13] Preserve mono delivery time (EDT) in skb->tstamp

On Wed, Mar 2, 2022 at 11:55 AM Martin KaFai Lau <> wrote:
> skb->tstamp was first used as the (rcv) timestamp.
> The major usage is to report it to the user (e.g. SO_TIMESTAMP).
> Later, skb->tstamp is also set as the (future) delivery_time (e.g. EDT in TCP)
> during egress and used by the qdisc (e.g. sch_fq) to make decision on when
> the skb can be passed to the dev.
> Currently, there is no way to tell skb->tstamp having the (rcv) timestamp
> or the delivery_time, so it is always reset to 0 whenever forwarded
> between egress and ingress.
> While it makes sense to always clear the (rcv) timestamp in skb->tstamp
> to avoid confusing sch_fq that expects the delivery_time, it is a
> performance issue [0] to clear the delivery_time if the skb finally
> egress to a fq@...-dev.
> This set is to keep the mono delivery time and make it available to
> the final egress interface.  Please see individual patch for
> the details.
> [0] (slide 22):

For the whole series

Reviewed-by: Eric Dumazet <>

Thanks !

Powered by blists - more mailing lists