netdev - Re: [net-next v9 0/2] net: sched: allow user to select txqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Mar 2022 06:33:52 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     xiangxia.m.yue@...il.com, netdev@...r.kernel.org,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        "David S. Miller" <davem@...emloft.net>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Alexander Lobakin <alobakin@...me>,
        Paolo Abeni <pabeni@...hat.com>,
        Talal Ahmad <talalahmad@...gle.com>,
        Kevin Hao <haokexin@...il.com>,
        Ilias Apalodimas <ilias.apalodimas@...aro.org>,
        Kees Cook <keescook@...omium.org>,
        Kumar Kartikeya Dwivedi <memxor@...il.com>,
        Antoine Tenart <atenart@...nel.org>,
        Wei Wang <weiwan@...gle.com>, Arnd Bergmann <arnd@...db.de>
Subject: Re: [net-next v9 0/2] net: sched: allow user to select txqueue

On 2022-03-02 14:24, Jakub Kicinski wrote:
> On Tue, 22 Feb 2022 19:23:24 +0800 xiangxia.m.yue@...il.com wrote:
>> From: Tonghao Zhang <xiangxia.m.yue@...il.com>
>>
>> Patch 1 allow user to select txqueue in clsact hook.
>> Patch 2 support skbhash, classid, cpuid to select txqueue.
> 
> Jamal, you had feedback on the previous version,
> does this one look good?

No it doesnt.
Maybe i wasnt clear enough to Tonghao because they sent out
a patch right after that discussion which didnt address my
last comments. Here's my take:

Out of the three options in 2/2 that Tonghao showed - I agree with
Cong on the last two (cpu and class): that user space can correctly set
policy without needing the specified mechanisms being added to the
kernel.
skbhash otoh is meaningful.

Patch 1 is useful irrespective of patch 2.

cheers,
jamal