netdev - Re: [PATCH net-next 1/7] net: dev: use kfree_skb_reason() for sch_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220303202539.17ac1dd5@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Thu, 3 Mar 2022 20:25:39 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     menglong8.dong@...il.com
Cc:     dsahern@...nel.org, rostedt@...dmis.org, mingo@...hat.com,
        davem@...emloft.net, ast@...nel.org, daniel@...earbox.net,
        hawk@...nel.org, john.fastabend@...il.com, imagedong@...cent.com,
        edumazet@...gle.com, talalahmad@...gle.com, keescook@...omium.org,
        ilias.apalodimas@...aro.org, alobakin@...me,
        flyingpeng@...cent.com, mengensun@...cent.com, atenart@...nel.org,
        bigeasy@...utronix.de, memxor@...il.com, arnd@...db.de,
        pabeni@...hat.com, willemb@...gle.com, vvs@...tuozzo.com,
        cong.wang@...edance.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH net-next 1/7] net: dev: use kfree_skb_reason() for
 sch_handle_egress()

On Fri,  4 Mar 2022 01:47:01 +0800 menglong8.dong@...il.com wrote:
> Replace kfree_skb() used in sch_handle_egress() with kfree_skb_reason().
> The drop reason SKB_DROP_REASON_QDISC_EGRESS is introduced. Considering
> the code path of qdisc egerss, we make it distinct with the drop reason
> of SKB_DROP_REASON_QDISC_DROP in the next commit.

I don't think this has much to do with Qdiscs, this is the TC
egress hook, it's more for filtering. Classful Qdisc like HTB 
will run its own classification. I think.

Maybe TC_EGRESS?