netdev - Re: [PATCH net v2] net: macb: Fix lost RX packet wakeup race in NAPI receive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <164639581051.6905.901376862020393638.git-patchwork-notify@kernel.org>
Date:   Fri, 04 Mar 2022 12:10:10 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Robert Hancock <robert.hancock@...ian.com>
Cc:     netdev@...r.kernel.org, nicolas.ferre@...rochip.com,
        claudiu.beznea@...rochip.com, davem@...emloft.net, kuba@...nel.org,
        soren.brinkmann@...inx.com, scott.mcnutt@...iusxm.com,
        stable@...r.kernel.org
Subject: Re: [PATCH net v2] net: macb: Fix lost RX packet wakeup race in NAPI
 receive

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@...emloft.net>:

On Thu,  3 Mar 2022 12:10:27 -0600 you wrote:
> There is an oddity in the way the RSR register flags propagate to the
> ISR register (and the actual interrupt output) on this hardware: it
> appears that RSR register bits only result in ISR being asserted if the
> interrupt was actually enabled at the time, so enabling interrupts with
> RSR bits already set doesn't trigger an interrupt to be raised. There
> was already a partial fix for this race in the macb_poll function where
> it checked for RSR bits being set and re-triggered NAPI receive.
> However, there was a still a race window between checking RSR and
> actually enabling interrupts, where a lost wakeup could happen. It's
> necessary to check again after enabling interrupts to see if RSR was set
> just prior to the interrupt being enabled, and re-trigger receive in that
> case.
> 
> [...]

Here is the summary with links:
  - [net,v2] net: macb: Fix lost RX packet wakeup race in NAPI receive
    https://git.kernel.org/netdev/net/c/0bf476fc3624

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html