netdev - RE: [PATCH v2] rdma: Fix res_print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OSAPR01MB75672F674485556F9DE61C92E3059@OSAPR01MB7567.jpnprd01.prod.outlook.com>
Date:   Fri, 4 Mar 2022 12:47:39 +0000
From:   Shangyan Zhou <sy.zhou@...mail.com>
To:     Leon Romanovsky <leon@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH v2] rdma: Fix res_print_uint()

Did you mean the function name?

I see some of the input values are uint32_t and other is uint64_t, so I added a res_print_u64() and submitted a new patch.

Thanks.

-----Original Message-----
From: Leon Romanovsky <leon@...nel.org> 
Sent: Friday, March 4, 2022 3:03 PM
To: Shangyan Zhou <sy.zhou@...mail.com>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH v2] rdma: Fix res_print_uint()

On Fri, Mar 04, 2022 at 11:00:28AM +0800, Shangyan Zhou wrote:
> Print unsigned int64 should use print_color_u64() and fmt string should be "%" PRIu64.
> 
> Signed-off-by: Shangyan Zhou <sy.zhou@...mail.com>
> ---
>  rdma/res.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rdma/res.c b/rdma/res.c
> index 21fef9bd..1af61aa6 100644
> --- a/rdma/res.c
> +++ b/rdma/res.c
> @@ -214,7 +214,7 @@ void res_print_uint(struct rd *rd, const char *name, uint64_t val,
>  	if (!nlattr)
>  		return;
>  	print_color_uint(PRINT_ANY, COLOR_NONE, name, name, val);
> -	print_color_uint(PRINT_FP, COLOR_NONE, NULL, " %d ", val);
> +	print_color_u64(PRINT_FP, COLOR_NONE, NULL, " %" PRIu64 " ", val);
>  }

Except the res_print_uint() that should be changed too, the patch LGTM.

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>