netdev - Re: [PATCH net-next] skb: make drop reason booleanable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 4 Mar 2022 08:36:25 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     David Ahern <dsahern@...il.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Menglong Dong <menglong8.dong@...il.com>
Subject: Re: [PATCH net-next] skb: make drop reason booleanable

On Fri, Mar 4, 2022 at 7:31 AM David Ahern <dsahern@...il.com> wrote:
>
> On 3/3/22 11:37 PM, Eric Dumazet wrote:
> > On Thu, Mar 3, 2022 at 9:22 PM Jakub Kicinski <kuba@...nel.org> wrote:
> >>
> >> On Thu,  3 Mar 2022 20:53:53 -0800 Jakub Kicinski wrote:
> >>> -     return false;
> >>> +     return __SKB_OKAY;
> >>
> >> s/__//
> >>
> >> I'll send a v2 if I get acks / positive feedback.
> >
> >
> > I am not a big fan of SKB_OKAY ?
> >
> > Maybe SKB_NOT_DROPPED_YET, or SKB_VALID_SO_FAR.
> >
> > Oh well, I am not good at names.
>
> SKB_DROP_EXPECTED or SKB_DROP_NORMAL? That said I thought consume_skb is
> for normal, release path and then kfree_skb is when an skb is dropped
> for unexpected reasons.

Jakub wanted to use a special value in the enum, so that md5 function
can return this value to tell to the caller :
(To remove the extra "enum skb_drop_reason *reason" parameter  )

    "Please proceed with this packet, md5 layer found nothing wrong with it."

Other TCP checks need to apply after this, we do not know yet if skb
is going to be dropped or consumed.