netdev - Re: [PATCH net-next 1/7] net: dev: use kfree_skb_reason() for sch_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Mar 2022 12:56:40 +0800
From:   Menglong Dong <menglong8.dong@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     David Ahern <dsahern@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>,
        David Miller <davem@...emloft.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        Menglong Dong <imagedong@...cent.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Talal Ahmad <talalahmad@...gle.com>,
        Kees Cook <keescook@...omium.org>,
        Ilias Apalodimas <ilias.apalodimas@...aro.org>,
        Alexander Lobakin <alobakin@...me>, flyingpeng@...cent.com,
        Mengen Sun <mengensun@...cent.com>,
        Antoine Tenart <atenart@...nel.org>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Kumar Kartikeya Dwivedi <memxor@...il.com>,
        Arnd Bergmann <arnd@...db.de>, Paolo Abeni <pabeni@...hat.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Vasily Averin <vvs@...tuozzo.com>,
        Cong Wang <cong.wang@...edance.com>,
        LKML <linux-kernel@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH net-next 1/7] net: dev: use kfree_skb_reason() for sch_handle_egress()

On Fri, Mar 4, 2022 at 12:25 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Fri,  4 Mar 2022 01:47:01 +0800 menglong8.dong@...il.com wrote:
> > Replace kfree_skb() used in sch_handle_egress() with kfree_skb_reason().
> > The drop reason SKB_DROP_REASON_QDISC_EGRESS is introduced. Considering
> > the code path of qdisc egerss, we make it distinct with the drop reason
> > of SKB_DROP_REASON_QDISC_DROP in the next commit.
>
> I don't think this has much to do with Qdiscs, this is the TC
> egress hook, it's more for filtering. Classful Qdisc like HTB
> will run its own classification. I think.
>
> Maybe TC_EGRESS?

You are right, I think I misunderstanded the concept of qdisc and tc before.
and seems all 'QDISC' here should be 'TC'? which means:

QDISC_EGRESS -> TC_EGRESS
QDISC_DROP -> TC_DROP
QDISC_INGRESS -> TC_INGRESS