netdev - Re: [PATCH net-next 3/9] net: sgi-xp: Use netif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YiJ3ITxRaXso5abf@swahl-home.5wahls.com>
Date:   Fri, 4 Mar 2022 14:31:29 -0600
From:   Steve Wahl <steve.wahl@....com>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Robin Holt <robinmholt@...il.com>,
        Steve Wahl <steve.wahl@....com>,
        Mike Travis <mike.travis@....com>
Subject: Re: [PATCH net-next 3/9] net: sgi-xp: Use netif_rx().

Reviewed-by: Steve Wahl <steve.wahl@....com>

On Thu, Mar 03, 2022 at 06:14:59PM +0100, Sebastian Andrzej Siewior wrote:
> Since commit
>    baebdf48c3600 ("net: dev: Makes sure netif_rx() can be invoked in any context.")
> 
> the function netif_rx() can be used in preemptible/thread context as
> well as in interrupt context.
> 
> Use netif_rx().
> 
> Cc: Robin Holt <robinmholt@...il.com>
> Cc: Steve Wahl <steve.wahl@....com>
> Cc: Mike Travis <mike.travis@....com>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> ---
>  drivers/misc/sgi-xp/xpnet.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/sgi-xp/xpnet.c b/drivers/misc/sgi-xp/xpnet.c
> index dab7b92db790a..50644f83e78ce 100644
> --- a/drivers/misc/sgi-xp/xpnet.c
> +++ b/drivers/misc/sgi-xp/xpnet.c
> @@ -247,7 +247,7 @@ xpnet_receive(short partid, int channel, struct xpnet_message *msg)
>  	xpnet_device->stats.rx_packets++;
>  	xpnet_device->stats.rx_bytes += skb->len + ETH_HLEN;
>  
> -	netif_rx_ni(skb);
> +	netif_rx(skb);
>  	xpc_received(partid, channel, (void *)msg);
>  }
>  
> -- 
> 2.35.1
> 

-- 
Steve Wahl, Hewlett Packard Enterprise