netdev - Re: [PATCH net-next] skb: make drop reason booleanable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJ_06Tz8qA26JsgG14XdHCcDbK91MCYqneygSuTRdzsDg@mail.gmail.com>
Date:   Thu, 3 Mar 2022 22:37:24 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>, David Ahern <dsahern@...il.com>,
        Menglong Dong <menglong8.dong@...il.com>
Subject: Re: [PATCH net-next] skb: make drop reason booleanable

On Thu, Mar 3, 2022 at 9:22 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Thu,  3 Mar 2022 20:53:53 -0800 Jakub Kicinski wrote:
> > -     return false;
> > +     return __SKB_OKAY;
>
> s/__//
>
> I'll send a v2 if I get acks / positive feedback.


I am not a big fan of SKB_OKAY ?

Maybe SKB_NOT_DROPPED_YET, or SKB_VALID_SO_FAR.

Oh well, I am not good at names.