netdev - Re: [RFC PATCH v2 07/19] vdpa: introduce config operations for associating ASID to a virtqueue group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJaqyWcAT05-MtOZkyiyNezSzEEmyyDdps0aWm7PMuyS4jqNdA@mail.gmail.com>
Date:   Fri, 4 Mar 2022 10:54:33 +0100
From:   Eugenio Perez Martin <eperezma@...hat.com>
To:     Gautam Dawar <gautam.dawar@...inx.com>
Cc:     Gautam Dawar <gdawar@...inx.com>,
        Martin Petrus Hubertus Habets <martinh@...inx.com>,
        Harpreet Singh Anand <hanand@...inx.com>, tanujk@...inx.com,
        Jason Wang <jasowang@...hat.com>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Zhu Lingshan <lingshan.zhu@...el.com>,
        Stefano Garzarella <sgarzare@...hat.com>,
        Xie Yongji <xieyongji@...edance.com>,
        Eli Cohen <elic@...dia.com>,
        Si-Wei Liu <si-wei.liu@...cle.com>,
        Parav Pandit <parav@...dia.com>,
        Longpeng <longpeng2@...wei.com>,
        virtualization <virtualization@...ts.linux-foundation.org>,
        linux-kernel@...r.kernel.org, kvm list <kvm@...r.kernel.org>,
        netdev@...r.kernel.org
Subject: Re: [RFC PATCH v2 07/19] vdpa: introduce config operations for
 associating ASID to a virtqueue group

On Thu, Feb 24, 2022 at 10:25 PM Gautam Dawar <gautam.dawar@...inx.com> wrote:
>
> This patch introduces a new bus operation to allow the vDPA bus driver
> to associate an ASID to a virtqueue group.
>
> Signed-off-by: Jason Wang <jasowang@...hat.com>
> Signed-off-by: Gautam Dawar <gdawar@...inx.com>
> ---
>  include/linux/vdpa.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h
> index de22ca1a8ef3..7386860c3995 100644
> --- a/include/linux/vdpa.h
> +++ b/include/linux/vdpa.h
> @@ -239,6 +239,12 @@ struct vdpa_map_file {
>   *                             @vdev: vdpa device
>   *                             Returns the iova range supported by
>   *                             the device.
> + * @set_group_asid:            Set address space identifier for a
> + *                             virtqueue group
> + *                             @vdev: vdpa device
> + *                             @group: virtqueue group
> + *                             @asid: address space id for this group
> + *                             Returns integer: success (0) or error (< 0)
>   * @set_map:                   Set device memory mapping (optional)
>   *                             Needed for device that using device
>   *                             specific DMA translation (on-chip IOMMU)
> @@ -321,6 +327,10 @@ struct vdpa_config_ops {
>                        u64 iova, u64 size, u64 pa, u32 perm, void *opaque);
>         int (*dma_unmap)(struct vdpa_device *vdev, unsigned int asid,
>                          u64 iova, u64 size);
> +       int (*set_group_asid)(struct vdpa_device *vdev, unsigned int group,
> +                             unsigned int asid);
> +
> +

Nit again, and Jason's patch already contained these, but I think
these two blank lines are introduced unintentionally.

>
>         /* Free device resources */
>         void (*free)(struct vdpa_device *vdev);
> --
> 2.25.0
>