netdev - Re: [PATCH] smsc95xx: Ignore -ENODEV errors when device is unplugged

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOMZO5Dvp-Fqad-snXC79E30rpROQtUygPJ-a5awjBdXVaRrhg@mail.gmail.com>
Date:   Sat, 5 Mar 2022 17:49:03 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Steve Glendinning <steve.glendinning@...well.net>,
        UNGLinuxDriver@...rochip.com, fntoth@...il.com,
        Martyn Welch <martyn.welch@...labora.com>,
        netdev <netdev@...r.kernel.org>,
        USB list <linux-usb@...r.kernel.org>,
        Fabio Estevam <festevam@...x.de>
Subject: Re: [PATCH] smsc95xx: Ignore -ENODEV errors when device is unplugged

Hi Andrew,

On Sat, Mar 5, 2022 at 4:24 PM Andrew Lunn <andrew@...n.ch> wrote:

> Please indicate what tree this patch is actually for. It should be
> against net, since you want it backporting. Please see the netdev FAQ.
> Please also include a Fixes: tag.

Thanks for your review. Fixed in v2.

> I suspect this will result in kasan warnings. The contents of buf is
> probably undefined because of the error, yet you continue to set *data
> to it. You probably need to explicitly handle the ENODEV case setting
> *data to some value.

Good catch. Fixed in v2.

Thanks