netdev - Re: [PATCH net-next?] net: fungible: fix multiple build problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220304194116.613d2fd5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 4 Mar 2022 19:41:16 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Dimitris Michailidis <d.michailidis@...gible.com>
Cc:     Randy Dunlap <rdunlap@...radead.org>, netdev@...r.kernel.org,
        patches@...ts.linux.dev,
        Dimitris Michailidis <dmichail@...gible.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next?] net: fungible: fix multiple build problems

On Fri, 4 Mar 2022 16:39:49 -0800 Dimitris Michailidis wrote:
> > Also, gcc 7.5 does not handle the "C language" vs. #ifdef preprocessor
> > usage of IS_ENABLED() very well -- it is causing compile errors.  
> 
> I believe this is the source of the errors you see but it's not the compiler's
> fault or something specific to 7.5.0. The errors are because when
> IS_ENABLED() is false some of the symbols in the "if" are undefined and the
> compiler checks them regardless.

The compiler will need at least a declaration, right? tls_driver_ctx()
is pretty stupidly hidden under an ifdef, for reasons which I cannot
recall. Maybe we can take it out? 

Same thing could work for fun_tls_tx():

        return skb;
 }
+#else
+struct sk_buff *fun_tls_tx(struct sk_buff *skb, struct funeth_txq *q,
+                          unsigned int *tls_len);
 #endif
 
no?