netdev - Re: [PATCH v2 net-next] net: dsa: unlock the rtnl_mutex when dsa_master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220305123234.z7dotdedlqdsokj6@skbuf>
Date:   Sat, 5 Mar 2022 14:32:34 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: [PATCH v2 net-next] net: dsa: unlock the rtnl_mutex when
 dsa_master_setup() fails

On Fri, Mar 04, 2022 at 08:56:59PM -0800, Jakub Kicinski wrote:
> On Thu,  3 Mar 2022 16:08:40 +0200 Vladimir Oltean wrote:
> > Subject: [PATCH v2 net-next] net: dsa: unlock the rtnl_mutex when dsa_master_setup() fails
> 
> Did you mean s/-next//?

I really meant net-next, but now I see that I was wrong.
What I did was:

git tag --contains c146f9bc195a
v5.17-rc1
v5.17-rc2
v5.17-rc3
v5.17-rc4
v5.17-rc5
v5.17-rc6

and from this I drew the incorrect conclusion that the patch was merged
during the v5.17 rc's, for inclusion in v5.18.

> 
> > After the blamed commit, dsa_tree_setup_master() may exit without
> > calling rtnl_unlock(), fix that.
> > 
> > Fixes: c146f9bc195a ("net: dsa: hold rtnl_mutex when calling dsa_master_{setup,teardown}")
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> > ---
> > v1->v2: actually propagate the error code instead of always returning 0