lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 6 Mar 2022 07:00:12 +0000 From: Shangyan Zhou <sy.zhou@...mail.com> To: Leon Romanovsky <leon@...nel.org> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: RE: [PATCH v3] rdma: Fix res_print_uint() and add res_print_u64() Got it. I renamed it and submitted a new version. Thanks. -----Original Message----- From: Leon Romanovsky <leon@...nel.org> Sent: Saturday, March 5, 2022 1:34 AM To: Shangyan Zhou <sy.zhou@...mail.com> Cc: netdev@...r.kernel.org Subject: Re: [PATCH v3] rdma: Fix res_print_uint() and add res_print_u64() On Fri, Mar 04, 2022 at 08:46:37PM +0800, Shangyan Zhou wrote: > Use the corresponding function and fmt string to print unsigned int32 > and int64. > > Signed-off-by: Shangyan Zhou <sy.zhou@...mail.com> > --- > rdma/res-cq.c | 2 +- > rdma/res-mr.c | 2 +- > rdma/res-pd.c | 2 +- > rdma/res.c | 15 ++++++++++++--- > rdma/res.h | 4 +++- > rdma/stat.c | 4 ++-- > 6 files changed, 20 insertions(+), 9 deletions(-) > > diff --git a/rdma/res-cq.c b/rdma/res-cq.c index 9e7c4f51..475179c8 > 100644 > --- a/rdma/res-cq.c > +++ b/rdma/res-cq.c > @@ -112,7 +112,7 @@ static int res_cq_line(struct rd *rd, const char *name, int idx, > print_dev(rd, idx, name); > res_print_uint(rd, "cqn", cqn, nla_line[RDMA_NLDEV_ATTR_RES_CQN]); > res_print_uint(rd, "cqe", cqe, nla_line[RDMA_NLDEV_ATTR_RES_CQE]); > - res_print_uint(rd, "users", users, > + res_print_u64(rd, "users", users, > nla_line[RDMA_NLDEV_ATTR_RES_USECNT]); > print_poll_ctx(rd, poll_ctx, nla_line[RDMA_NLDEV_ATTR_RES_POLL_CTX]); > print_cq_dim_setting(rd, nla_line[RDMA_NLDEV_ATTR_DEV_DIM]); > diff --git a/rdma/res-mr.c b/rdma/res-mr.c index 1bf73f3a..a5b1ec5d > 100644 > --- a/rdma/res-mr.c > +++ b/rdma/res-mr.c > @@ -77,7 +77,7 @@ static int res_mr_line(struct rd *rd, const char *name, int idx, > print_key(rd, "rkey", rkey, nla_line[RDMA_NLDEV_ATTR_RES_RKEY]); > print_key(rd, "lkey", lkey, nla_line[RDMA_NLDEV_ATTR_RES_LKEY]); > print_key(rd, "iova", iova, nla_line[RDMA_NLDEV_ATTR_RES_IOVA]); > - res_print_uint(rd, "mrlen", mrlen, nla_line[RDMA_NLDEV_ATTR_RES_MRLEN]); > + res_print_u64(rd, "mrlen", mrlen, > +nla_line[RDMA_NLDEV_ATTR_RES_MRLEN]); > res_print_uint(rd, "pdn", pdn, nla_line[RDMA_NLDEV_ATTR_RES_PDN]); > res_print_uint(rd, "pid", pid, nla_line[RDMA_NLDEV_ATTR_RES_PID]); > print_comm(rd, comm, nla_line); > diff --git a/rdma/res-pd.c b/rdma/res-pd.c index df538010..6fec787c > 100644 > --- a/rdma/res-pd.c > +++ b/rdma/res-pd.c > @@ -65,7 +65,7 @@ static int res_pd_line(struct rd *rd, const char *name, int idx, > res_print_uint(rd, "pdn", pdn, nla_line[RDMA_NLDEV_ATTR_RES_PDN]); > print_key(rd, "local_dma_lkey", local_dma_lkey, > nla_line[RDMA_NLDEV_ATTR_RES_LOCAL_DMA_LKEY]); > - res_print_uint(rd, "users", users, > + res_print_u64(rd, "users", users, > nla_line[RDMA_NLDEV_ATTR_RES_USECNT]); > print_key(rd, "unsafe_global_rkey", unsafe_global_rkey, > nla_line[RDMA_NLDEV_ATTR_RES_UNSAFE_GLOBAL_RKEY]); > diff --git a/rdma/res.c b/rdma/res.c > index 21fef9bd..62599095 100644 > --- a/rdma/res.c > +++ b/rdma/res.c > @@ -51,7 +51,7 @@ static int res_print_summary(struct rd *rd, struct > nlattr **tb) > > name = mnl_attr_get_str(nla_line[RDMA_NLDEV_ATTR_RES_SUMMARY_ENTRY_NAME]); > curr = mnl_attr_get_u64(nla_line[RDMA_NLDEV_ATTR_RES_SUMMARY_ENTRY_CURR]); > - res_print_uint( > + res_print_u64( > rd, name, curr, > nla_line[RDMA_NLDEV_ATTR_RES_SUMMARY_ENTRY_CURR]); > } > @@ -208,13 +208,22 @@ void print_key(struct rd *rd, const char *name, uint64_t val, > print_color_hex(PRINT_ANY, COLOR_NONE, name, " 0x%" PRIx64 " ", > val); } > > -void res_print_uint(struct rd *rd, const char *name, uint64_t val, > +void res_print_uint(struct rd *rd, const char *name, uint32_t val, > struct nlattr *nlattr) It is res_print_u32() now and not res_print_uint(). But it is nitpicking. Thanks, Reviewed-by: Leon Romanovsky <leonro@...dia.com>
Powered by blists - more mailing lists