lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 6 Mar 2022 10:53:30 +0100 From: Oliver Hartkopp <socketcan@...tkopp.net> To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>, netdev@...r.kernel.org Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Thomas Gleixner <tglx@...utronix.de> Subject: Re: [PATCH net-next 4/8] slip/plip: Use netif_rx(). On 05.03.22 23:12, Sebastian Andrzej Siewior wrote: > Since commit > baebdf48c3600 ("net: dev: Makes sure netif_rx() can be invoked in any context.") > > the function netif_rx() can be used in preemptible/thread context as > well as in interrupt context. > > Use netif_rx(). > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de> Acked-by: Oliver Hartkopp <socketcan@...tkopp.net> (causing both patches) Thanks, Oliver > --- > drivers/net/plip/plip.c | 2 +- > drivers/net/slip/slip.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/plip/plip.c b/drivers/net/plip/plip.c > index 0d491b4d66675..dafd3e9ebbf87 100644 > --- a/drivers/net/plip/plip.c > +++ b/drivers/net/plip/plip.c > @@ -676,7 +676,7 @@ plip_receive_packet(struct net_device *dev, struct net_local *nl, > case PLIP_PK_DONE: > /* Inform the upper layer for the arrival of a packet. */ > rcv->skb->protocol=plip_type_trans(rcv->skb, dev); > - netif_rx_ni(rcv->skb); > + netif_rx(rcv->skb); > dev->stats.rx_bytes += rcv->length.h; > dev->stats.rx_packets++; > rcv->skb = NULL; > diff --git a/drivers/net/slip/slip.c b/drivers/net/slip/slip.c > index 98f586f910fb1..88396ff99f03f 100644 > --- a/drivers/net/slip/slip.c > +++ b/drivers/net/slip/slip.c > @@ -368,7 +368,7 @@ static void sl_bump(struct slip *sl) > skb_put_data(skb, sl->rbuff, count); > skb_reset_mac_header(skb); > skb->protocol = htons(ETH_P_IP); > - netif_rx_ni(skb); > + netif_rx(skb); > dev->stats.rx_packets++; > } >
Powered by blists - more mailing lists