netdev - Re: [PATCH net-next] net: dsa: tag_rtl8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <07287e42-bd51-a868-bfaa-6fd0213cc818@arinc9.com>
Date:   Mon, 7 Mar 2022 21:02:09 +0300
From:   Arınç ÜNAL <arinc.unal@...nc9.com>
To:     Luiz Angelo Daros de Luca <luizluca@...il.com>,
        netdev@...r.kernel.org
Cc:     linus.walleij@...aro.org, andrew@...n.ch, vivien.didelot@...il.com,
        f.fainelli@...il.com, olteanv@...il.com, davem@...emloft.net,
        kuba@...nel.org, alsi@...g-olufsen.dk
Subject: Re: [PATCH net-next] net: dsa: tag_rtl8_4: typo in modalias name

On 07/03/2022 20:09, Luiz Angelo Daros de Luca wrote:
> DSA_TAG_PROTO_RTL8_4L is not defined. It should be
> DSA_TAG_PROTO_RTL8_4T.
> 
> Reported-by: Arınç ÜNAL <arinc.unal@...nc9.com>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@...il.com>
> ---
>   net/dsa/tag_rtl8_4.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/dsa/tag_rtl8_4.c b/net/dsa/tag_rtl8_4.c
> index 71fec45fd0ea..a593ead7ff26 100644
> --- a/net/dsa/tag_rtl8_4.c
> +++ b/net/dsa/tag_rtl8_4.c
> @@ -247,7 +247,7 @@ static const struct dsa_device_ops rtl8_4t_netdev_ops = {
>   
>   DSA_TAG_DRIVER(rtl8_4t_netdev_ops);
>   
> -MODULE_ALIAS_DSA_TAG_DRIVER(DSA_TAG_PROTO_RTL8_4L);
> +MODULE_ALIAS_DSA_TAG_DRIVER(DSA_TAG_PROTO_RTL8_4T);
>   
>   static struct dsa_tag_driver *dsa_tag_drivers[] = {
>   	&DSA_TAG_DRIVER_NAME(rtl8_4_netdev_ops),

Might as well add Fixes: tag since this fixes cd87fecdedd7 ("net: dsa: 
tag_rtl8_4: add rtl8_4t trailing variant") and "fix typo in modalias 
name" on the subject to clearly state the change.

Arınç