netdev - Re: [PATCH 2/2] sch_fq_codel: fix running with classifiers that don't set a classid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 07 Mar 2022 21:41:01 +0100
From:   Toke Høiland-Jørgensen <toke@...hat.com>
To:     Felix Fietkau <nbd@....name>, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] sch_fq_codel: fix running with classifiers that
 don't set a classid

Felix Fietkau <nbd@....name> writes:

> If no valid classid is provided, fall back to calculating the hash directly,
> in order to avoid dropping packets
>
> Signed-off-by: Felix Fietkau <nbd@....name>

While I agree that this behaviour makes more sense, it's also a
user-facing API change; I suppose there may be filters out there relying
on the fact that invalid (or unset) class ID values lead to dropped
packets?

-Toke