netdev - Re: [PATCH net-next 8/9] bnxt_en: implement hw health reporter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220307142157.143c9beb@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 7 Mar 2022 14:21:57 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Michael Chan <michael.chan@...adcom.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, gospo@...adcom.com
Subject: Re: [PATCH net-next 8/9] bnxt_en: implement hw health reporter

On Sat,  5 Mar 2022 03:54:41 -0500 Michael Chan wrote:
> +static int bnxt_hw_recover(struct devlink_health_reporter *reporter,
> +			   void *priv_ctx,
> +			   struct netlink_ext_ack *extack)
> +{
> +	struct bnxt *bp = devlink_health_reporter_priv(reporter);
> +	struct bnxt_hw_health *hw_health = &bp->hw_health;
> +
> +	hw_health->synd = BNXT_HW_STATUS_HEALTHY;
> +	return 0;
> +}

This seems like a very weird recovery function.

I guess the FW automatically does auto-recovery and the driver 
has no control over it?