netdev - Re: [PATCH net-next v5 09/13] net: wwan: t7xx: Add WWAN network interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHNKnsQqC1B+5c0jDqD2WUR2HB_-WKV4nvsRoCK-1Sn95x6xDA@mail.gmail.com>
Date:   Mon, 7 Mar 2022 05:59:24 +0300
From:   Sergey Ryazanov <ryazanov.s.a@...il.com>
To:     Ricardo Martinez <ricardo.martinez@...ux.intel.com>
Cc:     netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
        Jakub Kicinski <kuba@...nel.org>,
        David Miller <davem@...emloft.net>,
        Johannes Berg <johannes@...solutions.net>,
        Loic Poulain <loic.poulain@...aro.org>,
        M Chetan Kumar <m.chetan.kumar@...el.com>,
        chandrashekar.devegowda@...el.com,
        Intel Corporation <linuxwwan@...el.com>,
        chiranjeevi.rapolu@...ux.intel.com,
        Haijun Liu (刘海军) 
        <haijun.liu@...iatek.com>, amir.hanania@...el.com,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        dinesh.sharma@...el.com, eliot.lee@...el.com,
        ilpo.johannes.jarvinen@...el.com, moises.veleta@...el.com,
        pierre-louis.bossart@...el.com, muralidharan.sethuraman@...el.com,
        Soumya.Prakash.Mishra@...el.com, sreehari.kancharla@...el.com,
        madhusmita.sahu@...el.com
Subject: Re: [PATCH net-next v5 09/13] net: wwan: t7xx: Add WWAN network interface

On Thu, Feb 24, 2022 at 1:35 AM Ricardo Martinez
<ricardo.martinez@...ux.intel.com> wrote:
> From: Haijun Liu <haijun.liu@...iatek.com>
>
> Creates the Cross Core Modem Network Interface (CCMNI) which implements
> the wwan_ops for registration with the WWAN framework, CCMNI also
> implements the net_device_ops functions used by the network device.
> Network device operations include open, close, start transmission, TX
> timeout, change MTU, and select queue.

[skipped]

> +static u16 t7xx_ccmni_select_queue(struct net_device *dev, struct sk_buff *skb,
> +                                  struct net_device *sb_dev)
> +{
> +       return DPMAIF_TX_DEFAULT_QUEUE;
> +}

[skipped]

> +static const struct net_device_ops ccmni_netdev_ops = {
> +       .ndo_open         = t7xx_ccmni_open,
> +       .ndo_stop         = t7xx_ccmni_close,
> +       .ndo_start_xmit   = t7xx_ccmni_start_xmit,
> +       .ndo_tx_timeout   = t7xx_ccmni_tx_timeout,
> +       .ndo_select_queue = t7xx_ccmni_select_queue,

Since the driver works in the single queue mode, this callback is unneeded.

> +};

--
Sergey