netdev - Re: [PATCH] nfp: xsk: avoid newline at the end of message in NL_SET_ERR_MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Mar 2022 10:27:10 +0100
From:   Niklas Söderlund 
        <niklas.soderlund@...igine.com>
To:     Guo Zhengkui <guozhengkui@...o.com>
Cc:     Simon Horman <simon.horman@...igine.com>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Louis Peens <louis.peens@...igine.com>,
        Yinjun Zhang <yinjun.zhang@...igine.com>,
        Paolo Abeni <pabeni@...hat.com>,
        "open list:NETRONOME ETHERNET DRIVERS" <oss-drivers@...igine.com>,
        "open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nfp: xsk: avoid newline at the end of message in
 NL_SET_ERR_MSG_MOD

Hi Guo,

Thanks for your work.

On 2022-03-07 17:07:59 +0800, Guo Zhengkui wrote:
> Fix the following coccicheck warning:
> drivers/net/ethernet/netronome/nfp/nfp_net_common.c:3434:8-48: WARNING
> avoid newline at end of message in NL_SET_ERR_MSG_MOD
> 
> Signed-off-by: Guo Zhengkui <guozhengkui@...o.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund@...igine.com>

> ---
>  drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> index 00a09b9e0aee..d5ff80a62882 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> @@ -3431,7 +3431,7 @@ nfp_net_check_config(struct nfp_net *nn, struct nfp_net_dp *dp,
>  
>  		if (xsk_pool_get_rx_frame_size(dp->xsk_pools[r]) < xsk_min_fl_bufsz) {
>  			NL_SET_ERR_MSG_MOD(extack,
> -					   "XSK buffer pool chunk size too small\n");
> +					   "XSK buffer pool chunk size too small");
>  			return -EINVAL;
>  		}
>  	}
> -- 
> 2.20.1
> 

-- 
Regards,
Niklas Söderlund