netdev - Re: [PATCH] ethernet: Fix error handling in xemaclite_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YidW4rzNQ3ckkO1Y@lunn.ch>
Date:   Tue, 8 Mar 2022 14:15:14 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Miaoqian Lin <linmq006@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Michal Simek <michal.simek@...inx.com>,
        Arnd Bergmann <arnd@...db.de>,
        Michael Walle <michael@...le.cc>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        YueHaibing <yuehaibing@...wei.com>,
        John Linn <john.linn@...inx.com>,
        Grant Likely <grant.likely@...retlab.ca>,
        Sadanand Mutyala <Sadanand.Mutyala@...inx.com>,
        netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ethernet: Fix error handling in xemaclite_of_probe

On Tue, Mar 08, 2022 at 02:47:49AM +0000, Miaoqian Lin wrote:
> This node pointer is returned by of_parse_phandle() with refcount
> incremented in this function. Calling of_node_put() to avoid the
> refcount leak. As the remove function do.
> 
> Fixes: 5cdaaa12866e ("net: emaclite: adding MDIO and phy lib support")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew