netdev - Re: [PATCH net-next] vxlan_core: delete unnecessary condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5657e464-0f06-5bdf-106f-1bc7687e5e42@nvidia.com>
Date:   Mon, 7 Mar 2022 19:46:28 -0800
From:   Roopa Prabhu <roopa@...dia.com>
To:     Nikolay Aleksandrov <razor@...ckwall.org>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Nikolay Aleksandrov <nikolay@...dia.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] vxlan_core: delete unnecessary condition


On 3/7/22 05:07, Nikolay Aleksandrov wrote:
> On 07/03/2022 15:05, Nikolay Aleksandrov wrote:
>> On 07/03/2022 14:57, Dan Carpenter wrote:
>>> The previous check handled the "if (!nh)" condition so we know "nh"
>>> is non-NULL here.  Delete the check and pull the code in one tab.
>>>
>>> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>>> ---
>>> This not a bug so a Fixes tag is innappropriate, however for reviewers
>>> this was introduced in commit 4095e0e1328a ("drivers: vxlan: vnifilter:
>>> per vni stats")
>> No, it was not introduced by that commit.
>> It was introduced by commit:
>>   1274e1cc4226 ("vxlan: ecmp support for mac fdb entries")
>>
> Forgot to add: patch looks good to me. :)
> Reviewed-by: Nikolay Aleksandrov <razor@...ckwall.org>

+1


Reviewed-by: Roopa Prabhu <roopa@...dia.com>

LGTM too, thanks Dan