netdev - [net-next:master 192/194] include/net/tcp.h:1694:1: warning: 'tcp_inbound_md5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 10 Mar 2022 00:19:36 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org,
        David Ahern <dsahern@...nel.org>
Subject: [net-next:master 192/194] include/net/tcp.h:1694:1: warning:
 'tcp_inbound_md5_hash' used but never defined

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head:   40bb09c87f0b00c991f6c2fb367f0a2711760332
commit: 1330b6ef3313fcec577d2b020c290dc8b9f11f1a [192/194] skb: make drop reason booleanable
config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20220310/202203100028.PDew5dU4-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=1330b6ef3313fcec577d2b020c290dc8b9f11f1a
        git remote add net-next https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
        git fetch --no-tags net-next master
        git checkout 1330b6ef3313fcec577d2b020c290dc8b9f11f1a
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash net/core/ net/ipv4/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from net/ipv4/tcp_ipv4.c:64:
   include/net/tcp.h:1697:1: error: expected identifier or '(' before '{' token
    1697 | {
         | ^
>> include/net/tcp.h:1694:1: warning: 'tcp_inbound_md5_hash' used but never defined
    1694 | tcp_inbound_md5_hash(const struct sock *sk, const struct sk_buff *skb,
         | ^~~~~~~~~~~~~~~~~~~~


vim +/tcp_inbound_md5_hash +1694 include/net/tcp.h

  1692	
  1693	static inline enum skb_drop_reason
> 1694	tcp_inbound_md5_hash(const struct sock *sk, const struct sk_buff *skb,
  1695			     const void *saddr, const void *daddr,
  1696			     int family, int dif, int sdif);
> 1697	{
  1698		return SKB_NOT_DROPPED_YET;
  1699	}
  1700	#define tcp_twsk_md5_key(twsk)	NULL
  1701	#endif
  1702	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org