netdev - Re: [PATCH net-next v2] net/fungible: CONFIG_FUN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ec5946d-a400-b3d9-3ec4-0200aac785f3@infradead.org>
Date:   Tue, 8 Mar 2022 18:57:02 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Dimitris Michailidis <d.michailidis@...gible.com>,
        davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] net/fungible: CONFIG_FUN_CORE needs SBITMAP



On 3/8/22 00:12, Dimitris Michailidis wrote:
> fun_core.ko uses sbitmaps and needs to select SBITMAP.
> Fixes below errors:
> 
> ERROR: modpost: "__sbitmap_queue_get"
> [drivers/net/ethernet/fungible/funcore/funcore.ko] undefined!
> ERROR: modpost: "sbitmap_finish_wait"
> [drivers/net/ethernet/fungible/funcore/funcore.ko] undefined!
> ERROR: modpost: "sbitmap_queue_clear"
> [drivers/net/ethernet/fungible/funcore/funcore.ko] undefined!
> ERROR: modpost: "sbitmap_prepare_to_wait"
> [drivers/net/ethernet/fungible/funcore/funcore.ko] undefined!
> ERROR: modpost: "sbitmap_queue_init_node"
> [drivers/net/ethernet/fungible/funcore/funcore.ko] undefined!
> ERROR: modpost: "sbitmap_queue_wake_all"
> [drivers/net/ethernet/fungible/funcore/funcore.ko] undefined!
> 
> v2: correct "Fixes" SHA
> 
> Fixes: 749efb1e6d73 ("net/fungible: Kconfig, Makefiles, and MAINTAINERS")
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Dimitris Michailidis <dmichail@...gible.com>

Acked-by: Randy Dunlap <rdunlap@...radead.org>


> ---
>  drivers/net/ethernet/fungible/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/fungible/Kconfig b/drivers/net/ethernet/fungible/Kconfig
> index 2ff5138d0448..1ecedecc0f6c 100644
> --- a/drivers/net/ethernet/fungible/Kconfig
> +++ b/drivers/net/ethernet/fungible/Kconfig
> @@ -18,6 +18,7 @@ if NET_VENDOR_FUNGIBLE
>  
>  config FUN_CORE
>  	tristate
> +	select SBITMAP
>  	help
>  	  A service module offering basic common services to Fungible
>  	  device drivers.

-- 
~Randy