netdev - Re: [PATCH net-next] net: tcp: fix shim definition of tcp_inbound_md5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iKQt2jB8WthN9h+rTogNYjULznyccLXMHhLiv__Qyygyw@mail.gmail.com>
Date:   Wed, 9 Mar 2022 08:41:21 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     netdev <netdev@...r.kernel.org>, Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH net-next] net: tcp: fix shim definition of tcp_inbound_md5_hash

On Wed, Mar 9, 2022 at 4:20 AM Vladimir Oltean <vladimir.oltean@....com> wrote:
>
> When CONFIG_TCP_MD5SIG isn't enabled, there is a compilation bug due to
> the fact that the static inline definition of tcp_inbound_md5_hash() has
> an unexpected semicolon. Remove it.
>
> Fixes: 1330b6ef3313 ("skb: make drop reason booleanable")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks!