netdev - RE: [EXT] Re: [PATCH v2 net-next 1/2] bnx2x: Utilize firmware 7.13.21.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY3PR18MB4612C2FFE05879E30BAD91D7AB0A9@BY3PR18MB4612.namprd18.prod.outlook.com>
Date:   Wed, 9 Mar 2022 19:46:24 +0000
From:   Manish Chopra <manishc@...vell.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
CC:     Paul Menzel <pmenzel@...gen.mpg.de>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Ariel Elior <aelior@...vell.com>,
        Alok Prasad <palok@...vell.com>,
        Prabhakar Kushwaha <pkushwaha@...vell.com>,
        "David S. Miller" <davem@...emloft.net>,
        Greg KH <gregkh@...uxfoundation.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "it+netdev@...gen.mpg.de" <it+netdev@...gen.mpg.de>,
        "regressions@...ts.linux.dev" <regressions@...ts.linux.dev>
Subject: RE: [EXT] Re: [PATCH v2 net-next 1/2] bnx2x: Utilize firmware
 7.13.21.0

> -----Original Message-----
> From: Linus Torvalds <torvalds@...ux-foundation.org>
> Sent: Thursday, March 10, 2022 12:55 AM
> To: Manish Chopra <manishc@...vell.com>
> Cc: Paul Menzel <pmenzel@...gen.mpg.de>; kuba@...nel.org;
> netdev@...r.kernel.org; Ariel Elior <aelior@...vell.com>; Alok Prasad
> <palok@...vell.com>; Prabhakar Kushwaha <pkushwaha@...vell.com>;
> David S. Miller <davem@...emloft.net>; Greg KH
> <gregkh@...uxfoundation.org>; stable@...r.kernel.org;
> it+netdev@...gen.mpg.de; regressions@...ts.linux.dev
> Subject: Re: [EXT] Re: [PATCH v2 net-next 1/2] bnx2x: Utilize firmware
> 7.13.21.0
> 
> On Wed, Mar 9, 2022 at 11:22 AM Manish Chopra <manishc@...vell.com>
> wrote:
> >
> > This move was intentional, as follow up driver flow
> > [bnx2x_compare_fw_ver()] needs to know which exact FW version (newer
> > or older fw version which will be decided at run time now) the function is
> supposed to be run with in order to compare against already loaded FW on
> the adapter to decide on function probe/init failure (as opposed to earlier
> where driver was always stick to the one specific/fixed firmware version). So
> for that reason I chose the right place to invoke the bnx2x_init_firmware()
> during the probe early instead of later stage.
> 
> .. but since that fundamentally DOES NOT WORK, we'll clearly have to revert
> that change.
> 
> Firmware loading cannot happen early in boot. End of story. You need to delay
> firmware loading until the device is actually opened.
> 
>                                  Linus

Hello Linus,

This has not changed anything functionally from driver/device perspective, FW is still being loaded only when device is opened.
bnx2x_init_firmware() [I guess, perhaps the name is misleading] just request_firmware() to prepare the metadata to be used when device will be opened.

Thanks,
Manish