netdev - Re: [PATCH] ethtool: Fix refcount leak in gfar_get_ts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e68aa1f1-233f-6e5b-21a6-0443d565ca65@intel.com>
Date:   Wed, 9 Mar 2022 12:19:03 -0800
From:   Jesse Brandeburg <jesse.brandeburg@...el.com>
To:     Miaoqian Lin <linmq006@...il.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        "David S. Miller" <davem@...emloft.net>,
        "Jakub Kicinski" <kuba@...nel.org>, Yangbo Lu <yangbo.lu@....com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ethtool: Fix refcount leak in gfar_get_ts_info

 > Subject: [PATCH] ethtool: Fix refcount leak in gfar_get_ts_info

should be:
[PATCH net v2] gianfar: ethtool: Fix refcount leak in gfar_get_ts_info

On 3/9/2022 1:11 AM, Miaoqian Lin wrote:
> The of_find_compatible_node() function returns a node pointer with
> refcount incremented, We should use of_node_put() on it when done
> Add the missing of_node_put() to release the refcount.
> 
> Fixes: 7349a74ea75c ("net: ethernet: gianfar_ethtool: get phc index through drvdata")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>
> ---
>   drivers/net/ethernet/freescale/gianfar_ethtool.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c
> index ff756265d58f..9a2c16d69e2c 100644
> --- a/drivers/net/ethernet/freescale/gianfar_ethtool.c
> +++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c
> @@ -1464,6 +1464,7 @@ static int gfar_get_ts_info(struct net_device *dev,
>   	ptp_node = of_find_compatible_node(NULL, NULL, "fsl,etsec-ptp");
>   	if (ptp_node) {
>   		ptp_dev = of_find_device_by_node(ptp_node);
> +		of_node_put(ptp_node);
>   		if (ptp_dev)
>   			ptp = platform_get_drvdata(ptp_dev);
>   	}

If you fix the subject and resend a v2, you can add
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>