netdev - Re: [PATCH iproute2-next v3 0/7] bridge: support for controlling broadcast flooding per port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <070b4dff-3d76-4b65-8f05-eb32e1f91743@blackwall.org>
Date:   Thu, 10 Mar 2022 11:01:46 +0200
From:   Nikolay Aleksandrov <razor@...ckwall.org>
To:     Joachim Wiberg <troglobit@...il.com>, netdev@...r.kernel.org
Cc:     David Ahern <dsahern@...nel.org>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2-next v3 0/7] bridge: support for controlling
 broadcast flooding per port

On 09/03/2022 21:23, Joachim Wiberg wrote:
> Hi,
> 
> this patch set address a slight omission in controlling broadcast
> flooding per bridge port, which the bridge has had support for a good
> while now.
> 
> v3:
>   - Move bcast_flood option in manual files to before the mcast_flood
>     option, instead of breaking the two mcast options.  Unfortunately
>     the other options are not alphabetically sorted, so this was the
>     least worst option. (Stephen)
>   - Add missing closing " for 'bridge mdb show' in bridge(8) SYNOPSIS
> v2:
>   - Add bcast_flood also to ip/iplink_bridge_slave.c (Nik)
>   - Update man page for ip-link(8) with new bcast_flood flag
>   - Update mcast_flood in same man page slightly
>   - Fix minor weird whitespace issues causing sudden line breaks
> v1:
>   - Add bcast_flood to bridge/link.c
>   - Update man page for bridge(8) with bcast_flood for brports
> 
> Best regards
>  /Joachim
> 
> Joachim Wiberg (7):
>   bridge: support for controlling flooding of broadcast per port
>   man: bridge: document new bcast_flood flag for bridge ports
>   man: bridge: add missing closing " in bridge show mdb
>   ip: iplink_bridge_slave: support for broadcast flooding
>   man: ip-link: document new bcast_flood flag on bridge ports
>   man: ip-link: mention bridge port's default mcast_flood state
>   man: ip-link: whitespace fixes to odd line breaks mid sentence
> 
>  bridge/link.c            | 13 +++++++++++++
>  ip/iplink_bridge_slave.c |  9 +++++++++
>  man/man8/bridge.8        |  8 +++++++-
>  man/man8/ip-link.8.in    | 20 +++++++++++++-------
>  4 files changed, 42 insertions(+), 8 deletions(-)
> 

Thank you, the patches look good to me.

For the set:
Reviewed-by: Nikolay Aleksandrov <razor@...ckwall.org>