netdev - Re: [PATCH net-next] flow_dissector: Add support for HSRv0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220310133403.bjf2k4tgpwl5xtsy@skbuf>
Date:   Thu, 10 Mar 2022 13:34:03 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Kurt Kanzenbach <kurt@...utronix.de>
CC:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Alexander Lobakin <alobakin@...me>,
        Eric Dumazet <edumazet@...gle.com>,
        Paul Blakey <paulb@...dia.com>,
        Yoshiki Komachi <komachi.yoshiki@...il.com>,
        zhang kai <zhangkaiheb@....com>,
        Juhee Kang <claudiajkang@...il.com>,
        Andreas Oetken <ennoerlangen@...il.com>,
        George McCollister <george.mccollister@...il.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Anthony Harivel <anthony.harivel@...utronix.de>
Subject: Re: [PATCH net-next] flow_dissector: Add support for HSRv0

On Thu, Mar 10, 2022 at 08:35:05AM +0100, Kurt Kanzenbach wrote:
> Commit bf08824a0f47 ("flow_dissector: Add support for HSR") added support for
> HSR within the flow dissector. However, it only works for HSR in version
> 1. Version 0 uses a different Ether Type. Add support for it.
> 
> Reported-by: Anthony Harivel <anthony.harivel@...utronix.de>
> Signed-off-by: Kurt Kanzenbach <kurt@...utronix.de>

This observation came up as a result of the fact that HSRv0 is still in
actual use, or just for correctness' sake?

> ---
>  net/core/flow_dissector.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
> index 34441a32e3be..03b6e649c428 100644
> --- a/net/core/flow_dissector.c
> +++ b/net/core/flow_dissector.c
> @@ -1283,6 +1283,7 @@ bool __skb_flow_dissect(const struct net *net,
>  		break;
>  	}
>  
> +	case htons(ETH_P_PRP):
>  	case htons(ETH_P_HSR): {
>  		struct hsr_tag *hdr, _hdr;
>  
> -- 
> 2.30.2
>