netdev - Re: [PATCH net-next] net: add per-cpu storage and net->core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202203100857.encufNnt-lkp@intel.com>
Date:   Thu, 10 Mar 2022 08:15:15 +0800
From:   kernel test robot <lkp@...el.com>
To:     Eric Dumazet <eric.dumazet@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     kbuild-all@...ts.01.org, netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        jeffreyji <jeffreyji@...gle.com>,
        Brian Vazquez <brianvv@...gle.com>
Subject: Re: [PATCH net-next] net: add per-cpu storage and net->core_stats

Hi Eric,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Eric-Dumazet/net-add-per-cpu-storage-and-net-core_stats/20220310-051831
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 7f415828f987fca9651694c7589560e55ffdf9a6
config: m68k-randconfig-r015-20220309 (https://download.01.org/0day-ci/archive/20220310/202203100857.encufNnt-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/9e6510e2ec32ebae0469ff500b2ba5bb2eb7a761
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Eric-Dumazet/net-add-per-cpu-storage-and-net-core_stats/20220310-051831
        git checkout 9e6510e2ec32ebae0469ff500b2ba5bb2eb7a761
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash drivers/media/dvb-frontends/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/media/dvb_net.h:22,
                    from drivers/media/usb/dvb-usb-v2/dvb_usb.h:19,
                    from drivers/media/dvb-frontends/rtl2832_sdr.c:12:
>> include/linux/netdevice.h:201:9: error: unknown type name 'local_t'
     201 |         local_t         rx_dropped;
         |         ^~~~~~~
   include/linux/netdevice.h:202:9: error: unknown type name 'local_t'
     202 |         local_t         tx_dropped;
         |         ^~~~~~~
   include/linux/netdevice.h:203:9: error: unknown type name 'local_t'
     203 |         local_t         rx_nohandler;
         |         ^~~~~~~
   In file included from include/linux/compiler_types.h:68,
                    from <command-line>:
>> include/linux/netdevice.h:204:24: error: 'local_t' undeclared here (not in a function)
     204 | } __aligned(4 * sizeof(local_t));
         |                        ^~~~~~~
   include/linux/compiler_attributes.h:33:68: note: in definition of macro '__aligned'
      33 | #define __aligned(x)                    __attribute__((__aligned__(x)))
         |                                                                    ^
   In file included from include/media/dvb_net.h:22,
                    from drivers/media/usb/dvb-usb-v2/dvb_usb.h:19,
                    from drivers/media/dvb-frontends/rtl2832_sdr.c:12:
   include/linux/netdevice.h: In function 'dev_core_stats_rx_dropped_inc':
>> include/linux/netdevice.h:3863:17: error: implicit declaration of function 'local_inc'; did you mean 'local_lock'? [-Werror=implicit-function-declaration]
    3863 |                 local_inc(&p->FIELD);                                           \
         |                 ^~~~~~~~~
   include/linux/netdevice.h:3865:1: note: in expansion of macro 'DEV_CORE_STATS_INC'
    3865 | DEV_CORE_STATS_INC(rx_dropped)
         | ^~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/local_t +201 include/linux/netdevice.h

   196	
   197	/* per-cpu stats, allocated on demand.
   198	 * Try to fit them in a single cache line, for dev_get_stats() sake.
   199	 */
   200	struct net_device_core_stats {
 > 201		local_t		rx_dropped;
 > 202		local_t		tx_dropped;
   203		local_t		rx_nohandler;
 > 204	} __aligned(4 * sizeof(local_t));
   205	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org