netdev - RE: [EXT] Re: [PATCH v2 net-next 1/2] bnx2x: Utilize firmware 7.13.21.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR18MB465582071EDA502A96E57096C40B9@PH0PR18MB4655.namprd18.prod.outlook.com>
Date:   Thu, 10 Mar 2022 19:14:14 +0000
From:   Ariel Elior <aelior@...vell.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Manish Chopra <manishc@...vell.com>
CC:     Paul Menzel <pmenzel@...gen.mpg.de>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Alok Prasad <palok@...vell.com>,
        Prabhakar Kushwaha <pkushwaha@...vell.com>,
        "David S. Miller" <davem@...emloft.net>,
        Greg KH <gregkh@...uxfoundation.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "it+netdev@...gen.mpg.de" <it+netdev@...gen.mpg.de>,
        "regressions@...ts.linux.dev" <regressions@...ts.linux.dev>
Subject: RE: [EXT] Re: [PATCH v2 net-next 1/2] bnx2x: Utilize firmware
 7.13.21.0

> On Wed, 9 Mar 2022 14:18:23 -0800 Linus Torvalds wrote:
> > On Wed, Mar 9, 2022 at 11:46 AM Manish Chopra <manishc@...vell.com>
> wrote:
> > >
> > > This has not changed anything functionally from driver/device
> perspective, FW is still being loaded only when device is opened.
> > > bnx2x_init_firmware() [I guess, perhaps the name is misleading] just
> request_firmware() to prepare the metadata to be used when device will be
> opened.
> >
> > So how do you explain the report by Paul Menzel that things used to
> > work and no longer work now?
> >
> > You can't do request_firmware() early. When you actually then push the
> > firmware to the device is immaterial - but request_firmware() has to
> > be done after the system is up and running.
> 
> Alright, I don't see a revert in my inbox, so let me double check.
> 
> Linus, is my understanding correct that our PR today should revert
> the patches in question [1]? Or just drop them from stable for now,
> and give Manish and team a week or two to figure out a fix?
> 
> Manish, assuming it's the former - would you be able to provide
> a revert within a couple of hours (and I mean  "couple" in the
> British sense of roughly two)?
> 
> [1] patches in question:
>  e13ad1443684 ("bnx2x: fix driver load from initrd")
>  802d4d207e75 ("bnx2x: Invalidate fastpath HSI version for VFs")
>  b7a49f73059f ("bnx2x: Utilize firmware 7.13.21.0")

Jackub, assuming former, we won't be able to provide anything in a couple of hours
(already past midnight in Manish's part of the world).

Linus, does "you can't request FW before system is up and running" translate to
"don't request FW at probe" or "don't request FW in initrd?"
Or perhaps something else?

Thanks,
Ariel