netdev - RE: [PATCH net v2] gianfar: ethtool: Fix refcount leak in gfar_get_ts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM9PR04MB8397C4159072C82CD99895EF960B9@AM9PR04MB8397.eurprd04.prod.outlook.com>
Date:   Thu, 10 Mar 2022 07:23:54 +0000
From:   Claudiu Manoil <claudiu.manoil@....com>
To:     Miaoqian Lin <linmq006@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "Y.B. Lu" <yangbo.lu@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net v2] gianfar: ethtool: Fix refcount leak in
 gfar_get_ts_info

> -----Original Message-----
> From: Miaoqian Lin <linmq006@...il.com>
> Sent: Thursday, March 10, 2022 3:53 AM
> To: Claudiu Manoil <claudiu.manoil@....com>; David S. Miller
> <davem@...emloft.net>; Jakub Kicinski <kuba@...nel.org>; Y.B. Lu
> <yangbo.lu@....com>; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Cc: linmq006@...il.com
> Subject: [PATCH net v2] gianfar: ethtool: Fix refcount leak in gfar_get_ts_info
> 
> The of_find_compatible_node() function returns a node pointer with
> refcount incremented, We should use of_node_put() on it when done
> Add the missing of_node_put() to release the refcount.
> 
> Fixes: 7349a74ea75c ("net: ethernet: gianfar_ethtool: get phc index through
> drvdata")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> ---
> changes in v2:
> - Fix the subject
> ---

Reviewed-by: Claudiu Manoil <claudiu.manoil@....com>