netdev - Re: [PATCH v3] vsock: each transport cycles only on its own sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220310175025.69e35aaf@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 10 Mar 2022 17:50:25 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jiyong Park <jiyong@...gle.com>
Cc:     "Michael S. Tsirkin" <mst@...hat.com>,
        Stefano Garzarella <sgarzare@...hat.com>,
        Stefan Hajnoczi <stefanha@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        "David S. Miller" <davem@...emloft.net>, adelva@...gle.com,
        kvm@...r.kernel.org, virtualization@...ts.linux-foundation.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] vsock: each transport cycles only on its own sockets

On Fri, 11 Mar 2022 10:26:08 +0900 Jiyong Park wrote:
> First of all, sorry for the stupid breakage I made in V2. I forgot to turn
> CONFIG_VMWARE_VMCI_VSOCKETS on when I did the build by
> myself. I turned it on later and fixed the build error in V3.
> 
> > Jiyong, would you mind collecting the tags from Stefano and Michael
> > and reposting? I fixed our build bot, it should build test the patch
> > - I can't re-run on an already ignored patch, sadly.  
> 
> Jakub, please bear with me; Could you explain what you exactly want
> me to do? I'm new to kernel development and don't know how changes
> which Stefano and Machael maintain get tested and staged.

I was just asking to send the same patch (v3) second time to kick off
a CI. You can change the subject prefix to "[PATCH net v3 resend]".
And add

Reviewed-by: Stefano Garzarella <sgarzare@...hat.com>
Acked-by: Michael S. Tsirkin <mst@...hat.com>

between the "Fixes:" and your "Signed-off-by:" tag, since the code will
be identical.

The CI didn't catch v3 because I fumbled patch filtering config.
Your posting was correct, it was entirely my error.