netdev - Re: [PATCH] net: phy: marvell: Fix invalid comparison in marvell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YiuXnx2C1tMzSZ+G@lunn.ch>
Date:   Fri, 11 Mar 2022 19:40:31 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Kurt Cancemi <kurt@...architecture.com>
Cc:     netdev@...r.kernel.org, linux@...linux.org.uk
Subject: Re: [PATCH] net: phy: marvell: Fix invalid comparison in
 marvell_{suspend,resume}()

On Fri, Mar 11, 2022 at 10:55:42AM -0500, Kurt Cancemi wrote:
> This bug resulted in not resuming and suspending both the fiber and copper
> modes. Only the current mode would be suspended.
> 
> Signed-off-by: Kurt Cancemi <kurt@...architecture.com>

Hi Kurt

Please take a look at the netdev FAQ. You should put the tree where
this should be merged into in the subject line.

Since this is a fix, you should also include a Fixes: tag indicating
where the bug was introduces. That helps with backporting.

Fixes: 3758be3dc162 ("Marvell phy: add functions to suspend and resume both interfaces: fiber and copper links.")

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew