netdev - Re: [PATCH v3 bpf-next] bpf: select proper size for bpf_prog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 12 Mar 2022 05:40:31 +0800
From:   kernel test robot <lkp@...el.com>
To:     Song Liu <song@...nel.org>, bpf@...r.kernel.org,
        netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, ast@...nel.org, daniel@...earbox.net,
        andrii@...nel.org, kernel-team@...com, edumazet@...gle.com,
        Song Liu <song@...nel.org>
Subject: Re: [PATCH v3 bpf-next] bpf: select proper size for bpf_prog_pack

Hi Song,

I love your patch! Yet something to improve:

[auto build test ERROR on bpf-next/master]

url:    https://github.com/0day-ci/linux/commits/Song-Liu/bpf-select-proper-size-for-bpf_prog_pack/20220310-023737
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: arm-randconfig-c002-20220311 (https://download.01.org/0day-ci/archive/20220312/202203120545.dI2S3hTQ-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/4d06f388e14c69d938cbc1e4081029c14d8bc654
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Song-Liu/bpf-select-proper-size-for-bpf_prog_pack/20220310-023737
        git checkout 4d06f388e14c69d938cbc1e4081029c14d8bc654
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   kernel/bpf/core.c: In function 'select_bpf_prog_pack_size':
>> kernel/bpf/core.c:846:16: error: 'PMD_SIZE' undeclared (first use in this function); did you mean 'P4D_SIZE'?
     846 |         size = PMD_SIZE * num_online_nodes();
         |                ^~~~~~~~
         |                P4D_SIZE
   kernel/bpf/core.c:846:16: note: each undeclared identifier is reported only once for each function it appears in


vim +846 kernel/bpf/core.c

   840	
   841	static size_t select_bpf_prog_pack_size(void)
   842	{
   843		size_t size;
   844		void *ptr;
   845	
 > 846		size = PMD_SIZE * num_online_nodes();
   847		ptr = module_alloc(size);
   848	
   849		/* Test whether we can get huge pages. If not just use PAGE_SIZE
   850		 * packs.
   851		 */
   852		if (!ptr || !is_vm_area_hugepages(ptr))
   853			size = PAGE_SIZE;
   854	
   855		vfree(ptr);
   856		return size;
   857	}
   858	

---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org