[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20220311021751.29958-1-baijiaju1990@gmail.com>
Date: Thu, 10 Mar 2022 18:17:51 -0800
From: Jia-Ju Bai <baijiaju1990@...il.com>
To: aspriel@...il.com, franky.lin@...adcom.com,
hante.meuleman@...adcom.com, chi-hsien.lin@...ineon.com,
wright.feng@...ineon.com, chung-hsien.hsu@...ineon.com,
kvalo@...nel.org, davem@...emloft.net, kuba@...nel.org,
len.baker@....com, gustavoars@...nel.org, shawn.guo@...aro.org
Cc: linux-wireless@...r.kernel.org,
brcm80211-dev-list.pdl@...adcom.com,
SHA-cyfmac-dev-list@...ineon.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, Jia-Ju Bai <baijiaju1990@...il.com>
Subject: [PATCH v2] brcmfmac: check the return value of devm_kzalloc() in brcmf_of_probe()
The function devm_kzalloc() in brcmf_of_probe() can fail, so its return
value should be checked.
Fixes: 29e354ebeeec ("brcmfmac: Transform compatible string for FW loading")
Reported-by: TOTE Robot <oslab@...nghua.edu.cn>
Signed-off-by: Jia-Ju Bai <baijiaju1990@...il.com>
---
v2:
* Add of_node_put() in error handling path.
Thank Kalle for good advice.
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
index 513c7e6421b2..15eb96e288af 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
@@ -80,6 +80,10 @@ void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type,
/* get rid of '/' in the compatible string to be able to find the FW */
len = strlen(tmp) + 1;
board_type = devm_kzalloc(dev, len, GFP_KERNEL);
+ if (!board_type) {
+ of_node_put(root);
+ return;
+ }
strscpy(board_type, tmp, len);
for (i = 0; i < board_type[i]; i++) {
if (board_type[i] == '/')
--
2.17.1
Powered by blists - more mailing lists