netdev - Re: [PATCH net-next 2/2] ice: Add inline flow director support for channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220310203416.3b725bd2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 10 Mar 2022 20:34:16 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Tony Nguyen <anthony.l.nguyen@...el.com>
Cc:     davem@...emloft.net, Kiran Patil <kiran.patil@...el.com>,
        netdev@...r.kernel.org, sudheer.mogilappagari@...el.com,
        sridhar.samudrala@...el.com, amritha.nambiar@...el.com,
        jiri@...dia.com, leonro@...dia.com,
        Bharathi Sreenivas <bharathi.sreenivas@...el.com>
Subject: Re: [PATCH net-next 2/2] ice: Add inline flow director support for
 channels

On Thu, 10 Mar 2022 15:12:35 -0800 Tony Nguyen wrote:
> Inline flow director can be configured for each TC via devlink
> params based interface.
> 
> /* Create 4 TCs */
> tc qdisc add dev enp175s0f0 root mqprio num_tc 4 map 0 1 2 3 \
>              queues 2@0 8@2 8@10 8@18 hw 1 mode channel
> 
> /* Enable inline flow director for TC1 and TC2 */
> devlink dev param set pci/0000:af:00.0 \
>         name tc_inline_fd value 6 cmode runtime
> 
> /* Dump inline flow director setting */
> devlink dev param show  pci/0000:af:00.0 name tc_inline_fd
> pci/0000:af:00.0:
>   name tc2_inline_fd type driver-specific
>     values:
>       cmode runtime value 6

Why is this in devlink and not ethtool?

All devlink params must be clearly documented.