lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 11 Mar 2022 20:20:26 -0800 From: Randy Dunlap <rdunlap@...radead.org> To: netdev@...r.kernel.org Cc: patches@...ts.linux.dev, Randy Dunlap <rdunlap@...radead.org>, Thomas Bogendoerfer <tsbogend@...ha.franken.de>, linux-mips@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Phil Sutter <n0-1@...ewrt.org>, Florian Fainelli <f.fainelli@...il.com>, Ralf Baechle <ralf@...ux-mips.org>, Daniel Walter <dwalter@...gle.com> Subject: [PATCH] MIPS: RB532: fix return value of __setup handler __setup() handlers should return 1 to obsolete_checksetup() in init/main.c to indicate that the boot option has been handled. A return of 0 causes the boot option/value to be listed as an Unknown kernel parameter and added to init's (limited) argument or environment strings. Also, error return codes don't mean anything to obsolete_checksetup() -- only non-zero (usually 1) or zero. So return 1 from setup_kmac(). Fixes: 9e21c7e40b7e ("MIPS: RB532: Replace parse_mac_addr() with mac_pton().") Fixes: 73b4390fb234 ("[MIPS] Routerboard 532: Support for base system") Signed-off-by: Randy Dunlap <rdunlap@...radead.org> From: Igor Zhbanov <i.zhbanov@...russia.ru> Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@...russia.ru Cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de> Cc: linux-mips@...r.kernel.org Cc: "David S. Miller" <davem@...emloft.net> Cc: Jakub Kicinski <kuba@...nel.org> Cc: Phil Sutter <n0-1@...ewrt.org> Cc: Florian Fainelli <f.fainelli@...il.com> Cc: Ralf Baechle <ralf@...ux-mips.org> Cc: Daniel Walter <dwalter@...gle.com> --- arch/mips/rb532/devices.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) --- linux-next-20220309.orig/arch/mips/rb532/devices.c +++ linux-next-20220309/arch/mips/rb532/devices.c @@ -301,11 +301,9 @@ static int __init plat_setup_devices(voi static int __init setup_kmac(char *s) { printk(KERN_INFO "korina mac = %s\n", s); - if (!mac_pton(s, korina_dev0_data.mac)) { + if (!mac_pton(s, korina_dev0_data.mac)) printk(KERN_ERR "Invalid mac\n"); - return -EINVAL; - } - return 0; + return 1; } __setup("kmac=", setup_kmac);
Powered by blists - more mailing lists