netdev - Re: [PATCH v2 net] net: phy: marvell: Fix invalid comparison in the resume and suspend functions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 12 Mar 2022 20:16:16 +0000
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Marek Behún <kabel@...nel.org>
Cc:     Kurt Cancemi <kurt@...architecture.com>, netdev@...r.kernel.org,
        andrew@...n.ch
Subject: Re: [PATCH v2 net] net: phy: marvell: Fix invalid comparison in the
 resume and suspend functions.

On Sat, Mar 12, 2022 at 08:30:38PM +0100, Marek Behún wrote:
> On Fri, 11 Mar 2022 19:20:19 -0500
> Kurt Cancemi <kurt@...architecture.com> wrote:
> 
> > This bug resulted in only the current mode being resumed and suspended when
> > the PHY supported both fiber and copper modes and when the PHY only supported
> > copper mode the fiber mode would incorrectly be attempted to be resumed and
> > suspended.
> > 
> > Fixes: 3758be3dc162 ("Marvell phy: add functions to suspend and resume both interfaces: fiber and copper links.")
> > Signed-off-by: Kurt Cancemi <kurt@...architecture.com>
> 
> Nitpick: We don't use dots to end subject lines.

However, the commit in question has, and the Fixes: quoted summary line
needs to exactly match the summary line from the commit in question. So,
the fixes line is unfortunately correct in this instance.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!