lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 12 Mar 2022 20:04:12 -0800 From: Richard Cochran <richardcochran@...il.com> To: "Allan W. Nielsen" <allan.nielsen@...rochip.com> Cc: Horatiu Vultur <horatiu.vultur@...rochip.com>, "Russell King (Oracle)" <linux@...linux.org.uk>, Andrew Lunn <andrew@...n.ch>, Divya.Koppera@...rochip.com, netdev@...r.kernel.org, hkallweit1@...il.com, davem@...emloft.net, kuba@...nel.org, robh+dt@...nel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, UNGLinuxDriver@...rochip.com, Madhuri.Sripada@...rochip.com, Manohar.Puri@...rochip.com Subject: Re: [PATCH net-next 2/3] dt-bindings: net: micrel: Configure latency values and timestamping check for LAN8814 phy On Sat, Mar 12, 2022 at 08:36:20PM +0100, Allan W. Nielsen wrote: > I did skim through the articles, and as you hinted he does find small > latency differences across different packets. (but as I understood, very > few PHYs was tested). There is also previous work cited in those articles. > But this is not really an argument for not having _default_ values > hard-coded in the driver (or DT, but lets forget about DT for now). You put them in the DTS. That means you expect them to need changes. DTS is the WRONG place for such things. If your numbers are perfect, then do the corrections in silicon/firmware. If the numbers aren't 100% perfect, then provide your customers with a test report providing the recommended numbers. Include a proper explanation of the test methodology and assumptions used in your analysis. Heck, you can even given them linuxptp config snippets (and other for other popular PTP stacks, Oregano, ixat, ptpd, etc) Don't hard code random, changing numbers into kernel drivers. Thanks, Richard
Powered by blists - more mailing lists