netdev - Re: [PATCH RFT] can: mcba_usb: properly check endpoint type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b4beccd5-fa8b-b1cd-448f-96cb8d486059@gmail.com>
Date:   Sun, 13 Mar 2022 12:41:06 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Yasushi SHOJI <yashi@...cecubics.com>
Cc:     Vincent MAILHOL <mailhol.vincent@...adoo.fr>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        linux-can <linux-can@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        syzbot+3bc1dce0cc0052d60fde@...kaller.appspotmail.com
Subject: Re: [PATCH RFT] can: mcba_usb: properly check endpoint type

Hi Yasushi,

On 3/9/22 05:58, Yasushi SHOJI wrote:
> Hi Pavel,
> 
> On Tue, Mar 8, 2022 at 5:06 PM Pavel Skripkin <paskripkin@...il.com> wrote:
>> On 3/8/22 03:23, Vincent MAILHOL wrote:
>> >> [PATCH RFT] can: mcba_usb: properly check endpoint type
>> > It is RFC, not RFT :)
>> > I guess you went on some manual editing. Next time, you can just let
>> > git add the tag for you by doing:
>> > | git format-patch --rfc ...
>> >
>>
>> I marked it as RFT, because I wanted someone to test it. But indeed with
>> my lack of usb knowledge it should have been RFC :)
> 
> l didn't know RFT to mean "Request for Testing" :D
> 
> I have the device and do testing.  Do you have test code I can run?
> 

Sorry for late reply, this mail got somehow lost in my inbox.

I don't have any code and even this device.

I think, if with this patch applied driver probes and in-out stream 
works nice then this patch is correct :)




With regards,
Pavel Skripkin