netdev - Re: [PATCH v7 2/4] vdpa: Allow for printing negotiated features of a device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9e95f95-6ae7-518a-329b-3195e25a15e8@kernel.org>
Date:   Mon, 14 Mar 2022 08:51:54 -0600
From:   David Ahern <dsahern@...nel.org>
To:     Eli Cohen <elic@...dia.com>,
        Stephen Hemminger <stephen@...workplumber.org>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "virtualization@...ts.linux-foundation.org" 
        <virtualization@...ts.linux-foundation.org>,
        "jasowang@...hat.com" <jasowang@...hat.com>,
        "si-wei.liu@...cle.com" <si-wei.liu@...cle.com>,
        "mst@...hat.com" <mst@...hat.com>,
        "lulu@...hat.com" <lulu@...hat.com>,
        Parav Pandit <parav@...dia.com>
Subject: Re: [PATCH v7 2/4] vdpa: Allow for printing negotiated features of a
 device

On 3/13/22 12:04 PM, Eli Cohen wrote:
>>
>> On Sun, 13 Mar 2022 19:12:17 +0200
>> Eli Cohen <elic@...dia.com> wrote:
>>
>>> +			if (feature_strs)
>>> +				s = feature_strs[i];
>>> +			else
>>> +				s = NULL;
>>
>> You really don't like trigraphs?
>> 			s = feature_strs ? feature_strs[i] : NULL;
>> is more compact
> 
> If you insist I will send another version.
> Let me know.

I'll change it before applying