netdev - Re: [PATCH v7 3/4] vdpa: Support for configuring max VQ pairs for a device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d9e4118-ee4d-0398-0db5-bd3521122734@kernel.org>
Date:   Mon, 14 Mar 2022 09:09:02 -0600
From:   David Ahern <dsahern@...nel.org>
To:     Eli Cohen <elic@...dia.com>, stephen@...workplumber.org,
        netdev@...r.kernel.org, virtualization@...ts.linux-foundation.org,
        jasowang@...hat.com, si-wei.liu@...cle.com
Cc:     mst@...hat.com, lulu@...hat.com, parav@...dia.com
Subject: Re: [PATCH v7 3/4] vdpa: Support for configuring max VQ pairs for a
 device

On 3/13/22 11:12 AM, Eli Cohen wrote:
> @@ -290,6 +295,14 @@ static int vdpa_argv_parse(struct vdpa *vdpa, int argc, char **argv,
>  
>  			NEXT_ARG_FWD();
>  			o_found |= VDPA_OPT_VDEV_MTU;
> +		} else if ((matches(*argv, "max_vqp")  == 0) && (o_optional & VDPA_OPT_MAX_VQP)) {
> +			NEXT_ARG_FWD();
> +			err = vdpa_argv_u16(vdpa, argc, argv, &opts->max_vqp);
> +			if (err)
> +				return err;
> +
> +			NEXT_ARG_FWD();
> +			o_found |= VDPA_OPT_MAX_VQP;
>  		} else {
>  			fprintf(stderr, "Unknown option \"%s\"\n", *argv);
>  			return -EINVAL;

new options require an update to the man page. That should have been
included in this set. Please make sure that happens on future sets.